From 3a11e1bd19ef36a07f6c3636e50d8544f02b6d12 Mon Sep 17 00:00:00 2001
From: Julian Orth <ju.orth@gmail.com>
Date: Sat, 13 Sep 2025 12:57:07 +0200
Subject: [PATCH] metal: improve logging

---
 src/backends/metal/monitor.rs |  4 ++++
 src/backends/metal/video.rs   | 22 ++++++++++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/backends/metal/monitor.rs b/src/backends/metal/monitor.rs
index 1da2f3ce..e5ca6daf 100644
--- a/src/backends/metal/monitor.rs
+++ b/src/backends/metal/monitor.rs
@@ -232,6 +232,10 @@ impl MetalBackend {
                 Some(d) if d.id == id => d,
                 _ => return,
             };
+            log::info!(
+                "Received logind response for drm device {}",
+                dev.devnode.to_bytes().as_bstr(),
+            );
             let res = match res {
                 Ok(r) => r,
                 Err(e) => {
diff --git a/src/backends/metal/video.rs b/src/backends/metal/video.rs
index faa4da72..c3b59a02 100644
--- a/src/backends/metal/video.rs
+++ b/src/backends/metal/video.rs
@@ -1083,6 +1083,11 @@ fn create_connector(
     dev: &Rc<MetalDrmDevice>,
 ) -> Result<(Rc<MetalConnector>, ConnectorFutures), DrmError> {
     let display = create_connector_display_data(connector, dev)?;
+    log::info!(
+        "Creating connector {} for device {}",
+        display.connector_id,
+        dev.devnode.as_bytes().as_bstr(),
+    );
     let slf = Rc::new(MetalConnector {
         id: connector,
         kernel_id: Cell::new(display.connector_id),
@@ -1799,6 +1804,11 @@ impl MetalBackend {
         for c in removed_connectors {
             dev.futures.remove(&c);
             if let Some(c) = dev.connectors.remove(&c) {
+                log::info!(
+                    "Removing connector {} from device {}",
+                    c.kernel_id.get(),
+                    dev.dev.devnode.as_bytes().as_bstr(),
+                );
                 if let Some(lease_id) = c.lease.get()
                     && let Some(lease) = dev.dev.leases.remove(&lease_id)
                     && !lease.try_revoke()
@@ -2467,7 +2477,11 @@ impl MetalBackend {
 
     fn re_init_drm_device(&self, dev: &Rc<MetalDrmDeviceData>) {
         if let Err(e) = self.init_drm_device(dev) {
-            log::error!("Could not initialize device: {}", ErrorFmt(e));
+            log::error!(
+                "Could not initialize drm device {}: {}",
+                dev.dev.devnode.as_bytes().as_bstr(),
+                ErrorFmt(e),
+            );
         }
         for connector in dev.connectors.lock().values() {
             if connector.connected() {
@@ -2552,7 +2566,11 @@ impl MetalBackend {
                 Ok(_) => break,
                 Err(e) => e,
             };
-            log::error!("Could not initialize DRM device: {}", ErrorFmt(&err));
+            log::error!(
+                "Could not initialize DRM device {}: {}",
+                dev.dev.devnode.as_bytes().as_bstr(),
+                ErrorFmt(&err),
+            );
             let Some(q) = quirks.pop() else {
                 return Err(err);
             };