1
0
Fork 0
forked from wry/wry

implement zwlr_foreign_toplevel_management protocol (#452)

* implement zwlr_foreign_toplevel_management protocol

* check if initial id is empty
This commit is contained in:
Mostafa Ibrahim 2025-05-28 14:53:29 +03:00 committed by GitHub
parent 3be8534683
commit 0930f00356
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 636 additions and 24 deletions

View file

@ -193,6 +193,7 @@ Jay supports the following wayland protocols:
| xdg_wm_base | 7 | | | xdg_wm_base | 7 | |
| xdg_wm_dialog_v1 | 1 | | | xdg_wm_dialog_v1 | 1 | |
| zwlr_data_control_manager_v1 | 2 | Yes | | zwlr_data_control_manager_v1 | 2 | Yes |
| zwlr_foreign_toplevel_manager_v1 | 3 | Yes |
| zwlr_layer_shell_v1 | 5 | No[^lsaccess] | | zwlr_layer_shell_v1 | 5 | No[^lsaccess] |
| zwlr_screencopy_manager_v1 | 3 | Yes | | zwlr_screencopy_manager_v1 | 3 | Yes |
| zwp_idle_inhibit_manager_v1 | 1 | | | zwp_idle_inhibit_manager_v1 | 1 | |

View file

@ -34,6 +34,7 @@
- Jay now supports being started with CAP_SYS_NICE capabilities to improve - Jay now supports being started with CAP_SYS_NICE capabilities to improve
responsiveness under high system load. This is described in detail in responsiveness under high system load. This is described in detail in
[setup.md](docs/setup.md). [setup.md](docs/setup.md).
- Implement wlr-foreign-toplevel-management-v1.
# 1.10.0 (2025-04-22) # 1.10.0 (2025-04-22)

View file

@ -63,6 +63,7 @@ bitflags! {
CAP_DRM_LEASE = 1 << 9, CAP_DRM_LEASE = 1 << 9,
CAP_INPUT_METHOD = 1 << 10, CAP_INPUT_METHOD = 1 << 10,
CAP_WORKSPACE = 1 << 11, CAP_WORKSPACE = 1 << 11,
CAP_FOREIGN_TOPLEVEL_MANAGER = 1 << 12,
} }
pub const CAPS_DEFAULT: ClientCaps = ClientCaps(CAP_LAYER_SHELL.0 | CAP_DRM_LEASE.0); pub const CAPS_DEFAULT: ClientCaps = ClientCaps(CAP_LAYER_SHELL.0 | CAP_DRM_LEASE.0);

View file

@ -333,6 +333,7 @@ fn start_compositor2(
cl_matcher_manager: ClMatcherManager::new(&crit_ids), cl_matcher_manager: ClMatcherManager::new(&crit_ids),
tl_matcher_manager: TlMatcherManager::new(&crit_ids), tl_matcher_manager: TlMatcherManager::new(&crit_ids),
caps_thread, caps_thread,
toplevel_managers: Default::default(),
}); });
state.tracker.register(ClientId::from_raw(0)); state.tracker.register(ClientId::from_raw(0));
create_dummy_output(&state); create_dummy_output(&state);

View file

@ -415,7 +415,7 @@ impl ConfigProxyHandler {
fullscreen: bool, fullscreen: bool,
) -> Result<(), CphError> { ) -> Result<(), CphError> {
let tl = self.get_window(window)?; let tl = self.get_window(window)?;
tl.tl_set_fullscreen(fullscreen); tl.tl_set_fullscreen(fullscreen, None);
Ok(()) Ok(())
} }

View file

@ -58,6 +58,7 @@ use {
xdg_toplevel_tag_manager_v1::XdgToplevelTagManagerV1Global, xdg_toplevel_tag_manager_v1::XdgToplevelTagManagerV1Global,
xdg_wm_base::XdgWmBaseGlobal, xdg_wm_base::XdgWmBaseGlobal,
xdg_wm_dialog_v1::XdgWmDialogV1Global, xdg_wm_dialog_v1::XdgWmDialogV1Global,
zwlr_foreign_toplevel_manager_v1::ZwlrForeignToplevelManagerV1Global,
zwlr_layer_shell_v1::ZwlrLayerShellV1Global, zwlr_layer_shell_v1::ZwlrLayerShellV1Global,
zwlr_screencopy_manager_v1::ZwlrScreencopyManagerV1Global, zwlr_screencopy_manager_v1::ZwlrScreencopyManagerV1Global,
zwp_idle_inhibit_manager_v1::ZwpIdleInhibitManagerV1Global, zwp_idle_inhibit_manager_v1::ZwpIdleInhibitManagerV1Global,
@ -202,6 +203,7 @@ impl Globals {
add_singleton!(ZwpIdleInhibitManagerV1Global); add_singleton!(ZwpIdleInhibitManagerV1Global);
add_singleton!(ExtIdleNotifierV1Global); add_singleton!(ExtIdleNotifierV1Global);
add_singleton!(XdgToplevelDragManagerV1Global); add_singleton!(XdgToplevelDragManagerV1Global);
add_singleton!(ZwlrForeignToplevelManagerV1Global);
add_singleton!(ZwlrDataControlManagerV1Global); add_singleton!(ZwlrDataControlManagerV1Global);
add_singleton!(WpAlphaModifierV1Global); add_singleton!(WpAlphaModifierV1Global);
add_singleton!(ZwpVirtualKeyboardManagerV1Global); add_singleton!(ZwpVirtualKeyboardManagerV1Global);

View file

@ -81,6 +81,8 @@ pub mod xdg_toplevel_drag_v1;
pub mod xdg_toplevel_tag_manager_v1; pub mod xdg_toplevel_tag_manager_v1;
pub mod xdg_wm_base; pub mod xdg_wm_base;
pub mod xdg_wm_dialog_v1; pub mod xdg_wm_dialog_v1;
pub mod zwlr_foreign_toplevel_handle_v1;
pub mod zwlr_foreign_toplevel_manager_v1;
pub mod zwlr_layer_shell_v1; pub mod zwlr_layer_shell_v1;
pub mod zwlr_screencopy_frame_v1; pub mod zwlr_screencopy_frame_v1;
pub mod zwlr_screencopy_manager_v1; pub mod zwlr_screencopy_manager_v1;

View file

@ -474,7 +474,7 @@ impl WlSeatGlobal {
pub fn set_fullscreen(&self, fullscreen: bool) { pub fn set_fullscreen(&self, fullscreen: bool) {
if let Some(tl) = self.keyboard_node.get().node_toplevel() { if let Some(tl) = self.keyboard_node.get().node_toplevel() {
tl.tl_set_fullscreen(fullscreen); tl.tl_set_fullscreen(fullscreen, None);
} }
} }

View file

@ -302,7 +302,7 @@ impl Xwindow {
Change::Map => { Change::Map => {
self.data.state.map_tiled(self.clone()); self.data.state.map_tiled(self.clone());
if self.data.info.fullscreen.get() { if self.data.info.fullscreen.get() {
self.clone().tl_set_fullscreen(true); self.clone().tl_set_fullscreen(true, None);
} }
self.data.title_changed(); self.data.title_changed();
} }

View file

@ -18,6 +18,7 @@ use {
}, },
}, },
xdg_toplevel_drag_v1::XdgToplevelDragV1, xdg_toplevel_drag_v1::XdgToplevelDragV1,
zwlr_foreign_toplevel_manager_v1::ZwlrForeignToplevelManagerV1,
}, },
leaks::Tracker, leaks::Tracker,
object::{Object, Version}, object::{Object, Version},
@ -180,6 +181,10 @@ impl XdgToplevel {
self.toplevel_data.send(self.clone(), list); self.toplevel_data.send(self.clone(), list);
} }
pub fn manager_send_to(self: &Rc<Self>, manager: &ZwlrForeignToplevelManagerV1) {
self.toplevel_data.manager_send(self.clone(), manager);
}
pub fn send_current_configure(&self) { pub fn send_current_configure(&self) {
if self.drag.is_none() { if self.drag.is_none() {
let rect = self.xdg.absolute_desired_extents.get(); let rect = self.xdg.absolute_desired_extents.get();

View file

@ -0,0 +1,207 @@
use {
crate::{
client::{Client, ClientError},
ifs::wl_output::WlOutput,
leaks::Tracker,
object::{Object, Version},
tree::{Direction, OutputNode, ToplevelOpt},
wire::{ZwlrForeignToplevelHandleV1Id, zwlr_foreign_toplevel_handle_v1::*},
},
arrayvec::ArrayVec,
std::rc::Rc,
thiserror::Error,
};
const STATE_ACTIVATED: u32 = 2;
const STATE_FULLSCREEN: u32 = 3;
const FULLSCREEN_SINCE: Version = Version(2);
pub struct ZwlrForeignToplevelHandleV1 {
pub id: ZwlrForeignToplevelHandleV1Id,
pub client: Rc<Client>,
pub tracker: Tracker<Self>,
pub toplevel: ToplevelOpt,
pub version: Version,
}
impl ZwlrForeignToplevelHandleV1 {
fn detach(&self) {
if let Some(tl) = self.toplevel.get() {
tl.tl_data()
.manager_handles
.remove(&(self.client.id, self.id));
}
}
}
impl ZwlrForeignToplevelHandleV1RequestHandler for ZwlrForeignToplevelHandleV1 {
type Error = ZwlrForeignToplevelHandleV1Error;
fn destroy(&self, _req: Destroy, _slf: &Rc<Self>) -> Result<(), Self::Error> {
self.detach();
self.client.remove_obj(self)?;
Ok(())
}
fn set_maximized(&self, _req: SetMaximized, _slf: &Rc<Self>) -> Result<(), Self::Error> {
Ok(())
}
fn unset_maximized(&self, _req: UnsetMaximized, _slf: &Rc<Self>) -> Result<(), Self::Error> {
Ok(())
}
fn set_minimized(&self, _req: SetMinimized, _slf: &Rc<Self>) -> Result<(), Self::Error> {
Ok(())
}
fn unset_minimized(&self, _req: UnsetMinimized, _slf: &Rc<Self>) -> Result<(), Self::Error> {
Ok(())
}
fn activate(&self, req: Activate, _slf: &Rc<Self>) -> Result<(), Self::Error> {
if let Some(toplevel) = self.toplevel.get() {
if !toplevel.node_visible() {
return Ok(());
}
let seat = self.client.lookup(req.seat)?;
toplevel.node_do_focus(&seat.global, Direction::Unspecified);
}
Ok(())
}
fn close(&self, _req: Close, _slf: &Rc<Self>) -> Result<(), Self::Error> {
if let Some(toplevel) = self.toplevel.get() {
toplevel.tl_close();
}
Ok(())
}
fn set_rectangle(&self, _req: SetRectangle, _slf: &Rc<Self>) -> Result<(), Self::Error> {
Ok(())
}
fn set_fullscreen(&self, req: SetFullscreen, _slf: &Rc<Self>) -> Result<(), Self::Error> {
if let Some(toplevel) = self.toplevel.get() {
let ws = if req.output.is_some() {
self.client
.lookup(req.output)?
.global
.node()
.map(|node| node.ensure_workspace())
} else {
None
};
toplevel.tl_set_fullscreen(true, ws);
}
Ok(())
}
fn unset_fullscreen(&self, _req: UnsetFullscreen, _slf: &Rc<Self>) -> Result<(), Self::Error> {
if let Some(toplevel) = self.toplevel.get() {
toplevel.tl_set_fullscreen(false, None);
}
Ok(())
}
}
impl ZwlrForeignToplevelHandleV1 {
pub fn leave_output(&self, output: &Rc<OutputNode>) {
let bindings = output.global.bindings.borrow();
if let Some(bindings) = bindings.get(&self.client.id) {
for binding in bindings.values() {
self.send_output_leave(binding);
}
}
}
pub fn enter_output(&self, output: &Rc<OutputNode>) {
let bindings = output.global.bindings.borrow();
if let Some(bindings) = bindings.get(&self.client.id) {
for binding in bindings.values() {
self.send_output_enter(binding);
}
}
}
pub fn send_closed(&self) {
self.client.event(Closed { self_id: self.id });
}
pub fn send_done(&self) {
self.client.event(Done { self_id: self.id });
}
pub fn send_title(&self, title: &str) {
self.client.event(Title {
self_id: self.id,
title,
});
}
pub fn send_app_id(&self, app_id: &str) {
self.client.event(AppId {
self_id: self.id,
app_id,
});
}
pub fn send_state(&self, activated: bool, fullscreen: bool) {
let mut state: ArrayVec<u32, 2> = ArrayVec::new();
if activated {
state.push(STATE_ACTIVATED);
}
if self.version >= FULLSCREEN_SINCE {
if fullscreen {
state.push(STATE_FULLSCREEN);
}
}
self.client.event(State {
self_id: self.id,
state: &state,
});
}
#[expect(dead_code)]
pub fn send_parent(&self, parent: &Rc<ZwlrForeignToplevelHandleV1>) {
self.client.event(Parent {
self_id: self.id,
parent: parent.id,
});
}
pub fn send_output_enter(&self, output: &Rc<WlOutput>) {
self.client.event(OutputEnter {
self_id: self.id,
output: output.id,
});
}
pub fn send_output_leave(&self, output: &Rc<WlOutput>) {
self.client.event(OutputLeave {
self_id: self.id,
output: output.id,
});
}
}
object_base! {
self = ZwlrForeignToplevelHandleV1;
version = self.version;
}
impl Object for ZwlrForeignToplevelHandleV1 {
fn break_loops(&self) {
self.detach();
}
}
simple_add_obj!(ZwlrForeignToplevelHandleV1);
#[derive(Debug, Error)]
pub enum ZwlrForeignToplevelHandleV1Error {
#[error(transparent)]
ClientError(Box<ClientError>),
}
efrom!(ZwlrForeignToplevelHandleV1Error, ClientError);

View file

@ -0,0 +1,162 @@
use {
crate::{
client::{CAP_FOREIGN_TOPLEVEL_MANAGER, Client, ClientCaps, ClientError},
globals::{Global, GlobalName},
ifs::{
wl_surface::{x_surface::xwindow::Xwindow, xdg_surface::xdg_toplevel::XdgToplevel},
zwlr_foreign_toplevel_handle_v1::ZwlrForeignToplevelHandleV1,
},
leaks::Tracker,
object::{Object, Version},
tree::{NodeVisitorBase, ToplevelOpt},
wire::{ZwlrForeignToplevelManagerV1Id, zwlr_foreign_toplevel_manager_v1::*},
},
std::rc::Rc,
thiserror::Error,
};
pub struct ZwlrForeignToplevelManagerV1Global {
name: GlobalName,
}
impl ZwlrForeignToplevelManagerV1Global {
pub fn new(name: GlobalName) -> Self {
Self { name }
}
fn bind_(
self: Rc<Self>,
id: ZwlrForeignToplevelManagerV1Id,
client: &Rc<Client>,
version: Version,
) -> Result<(), ZwlrForeignToplevelManagerV1Error> {
let obj = Rc::new(ZwlrForeignToplevelManagerV1 {
id,
client: client.clone(),
tracker: Default::default(),
version,
});
track!(client, obj);
client.add_client_obj(&obj)?;
ZwlrToplevelVisitor { manager: &obj }.visit_display(&client.state.root);
client.state.toplevel_managers.set((client.id, id), obj);
Ok(())
}
}
struct ZwlrToplevelVisitor<'a> {
manager: &'a ZwlrForeignToplevelManagerV1,
}
impl NodeVisitorBase for ZwlrToplevelVisitor<'_> {
fn visit_toplevel(&mut self, node: &Rc<XdgToplevel>) {
node.manager_send_to(self.manager);
}
fn visit_xwindow(&mut self, node: &Rc<Xwindow>) {
node.toplevel_data.manager_send(node.clone(), self.manager);
}
}
pub struct ZwlrForeignToplevelManagerV1 {
pub id: ZwlrForeignToplevelManagerV1Id,
pub client: Rc<Client>,
pub tracker: Tracker<Self>,
pub version: Version,
}
impl ZwlrForeignToplevelManagerV1 {
pub fn detach(&self) {
self.client
.state
.toplevel_managers
.remove(&(self.client.id, self.id));
}
}
impl ZwlrForeignToplevelManagerV1RequestHandler for ZwlrForeignToplevelManagerV1 {
type Error = ZwlrForeignToplevelManagerV1Error;
fn stop(&self, _req: Stop, _slf: &Rc<Self>) -> Result<(), Self::Error> {
self.detach();
self.send_finished();
self.client.remove_obj(self)?;
Ok(())
}
}
impl ZwlrForeignToplevelManagerV1 {
pub fn send_finished(&self) {
self.client.event(Finished { self_id: self.id });
}
pub fn send_handle(&self, handle: &ZwlrForeignToplevelHandleV1) {
self.client.event(Toplevel {
self_id: self.id,
toplevel: handle.id,
});
}
pub fn publish_toplevel(&self, tl: ToplevelOpt) -> Option<Rc<ZwlrForeignToplevelHandleV1>> {
let id = match self.client.new_id() {
Ok(id) => id,
Err(e) => {
self.client.error(e);
return None;
}
};
let handle = Rc::new(ZwlrForeignToplevelHandleV1 {
id,
client: self.client.clone(),
tracker: Default::default(),
version: self.version,
toplevel: tl,
});
track!(self.client, handle);
self.client.add_server_obj(&handle);
self.send_handle(&handle);
Some(handle)
}
}
global_base!(
ZwlrForeignToplevelManagerV1Global,
ZwlrForeignToplevelManagerV1,
ZwlrForeignToplevelManagerV1Error
);
impl Global for ZwlrForeignToplevelManagerV1Global {
fn singleton(&self) -> bool {
true
}
fn version(&self) -> u32 {
3
}
fn required_caps(&self) -> ClientCaps {
CAP_FOREIGN_TOPLEVEL_MANAGER
}
}
simple_add_global!(ZwlrForeignToplevelManagerV1Global);
object_base! {
self = ZwlrForeignToplevelManagerV1;
version = self.version;
}
impl Object for ZwlrForeignToplevelManagerV1 {
fn break_loops(&self) {
self.detach();
}
}
simple_add_obj!(ZwlrForeignToplevelManagerV1);
#[derive(Debug, Error)]
pub enum ZwlrForeignToplevelManagerV1Error {
#[error(transparent)]
ClientError(Box<ClientError>),
}
efrom!(ZwlrForeignToplevelManagerV1Error, ClientError);

View file

@ -65,6 +65,7 @@ use {
wp_drm_lease_connector_v1::WpDrmLeaseConnectorV1, wp_drm_lease_connector_v1::WpDrmLeaseConnectorV1,
wp_drm_lease_device_v1::WpDrmLeaseDeviceV1Global, wp_drm_lease_device_v1::WpDrmLeaseDeviceV1Global,
wp_linux_drm_syncobj_manager_v1::WpLinuxDrmSyncobjManagerV1Global, wp_linux_drm_syncobj_manager_v1::WpLinuxDrmSyncobjManagerV1Global,
zwlr_foreign_toplevel_manager_v1::ZwlrForeignToplevelManagerV1,
zwlr_screencopy_frame_v1::ZwlrScreencopyFrameV1, zwlr_screencopy_frame_v1::ZwlrScreencopyFrameV1,
zwp_linux_dmabuf_feedback_v1::ZwpLinuxDmabufFeedbackV1, zwp_linux_dmabuf_feedback_v1::ZwpLinuxDmabufFeedbackV1,
zwp_linux_dmabuf_v1::ZwpLinuxDmabufV1Global, zwp_linux_dmabuf_v1::ZwpLinuxDmabufV1Global,
@ -104,7 +105,7 @@ use {
wheel::Wheel, wheel::Wheel,
wire::{ wire::{
ExtForeignToplevelListV1Id, ExtIdleNotificationV1Id, JayRenderCtxId, JaySeatEventsId, ExtForeignToplevelListV1Id, ExtIdleNotificationV1Id, JayRenderCtxId, JaySeatEventsId,
JayWorkspaceWatcherId, ZwpLinuxDmabufFeedbackV1Id, JayWorkspaceWatcherId, ZwlrForeignToplevelManagerV1Id, ZwpLinuxDmabufFeedbackV1Id,
}, },
xwayland::{self, XWaylandEvent}, xwayland::{self, XWaylandEvent},
}, },
@ -240,6 +241,8 @@ pub struct State {
pub tray_item_ids: TrayItemIds, pub tray_item_ids: TrayItemIds,
pub data_control_device_ids: DataControlDeviceIds, pub data_control_device_ids: DataControlDeviceIds,
pub workspace_managers: WorkspaceManagerState, pub workspace_managers: WorkspaceManagerState,
pub toplevel_managers:
CopyHashMap<(ClientId, ZwlrForeignToplevelManagerV1Id), Rc<ZwlrForeignToplevelManagerV1>>,
pub color_management_enabled: Cell<bool>, pub color_management_enabled: Cell<bool>,
pub color_manager: Rc<ColorManager>, pub color_manager: Rc<ColorManager>,
pub float_above_fullscreen: Cell<bool>, pub float_above_fullscreen: Cell<bool>,

View file

@ -20,6 +20,8 @@ use {
WlSurface, x_surface::xwindow::XwindowData, WlSurface, x_surface::xwindow::XwindowData,
xdg_surface::xdg_toplevel::XdgToplevelToplevelData, xdg_surface::xdg_toplevel::XdgToplevelToplevelData,
}, },
zwlr_foreign_toplevel_handle_v1::ZwlrForeignToplevelHandleV1,
zwlr_foreign_toplevel_manager_v1::ZwlrForeignToplevelManagerV1,
}, },
rect::Rect, rect::Rect,
state::State, state::State,
@ -38,11 +40,12 @@ use {
}, },
wire::{ wire::{
ExtForeignToplevelHandleV1Id, ExtImageCopyCaptureSessionV1Id, JayScreencastId, ExtForeignToplevelHandleV1Id, ExtImageCopyCaptureSessionV1Id, JayScreencastId,
JayToplevelId, JayToplevelId, ZwlrForeignToplevelHandleV1Id,
}, },
}, },
jay_config::{window, window::WindowType}, jay_config::{window, window::WindowType},
std::{ std::{
borrow::Borrow,
cell::{Cell, RefCell}, cell::{Cell, RefCell},
ops::Deref, ops::Deref,
rc::{Rc, Weak}, rc::{Rc, Weak},
@ -53,12 +56,12 @@ tree_id!(ToplevelNodeId);
pub trait ToplevelNode: ToplevelNodeBase { pub trait ToplevelNode: ToplevelNodeBase {
fn tl_surface_active_changed(&self, active: bool); fn tl_surface_active_changed(&self, active: bool);
fn tl_set_fullscreen(self: Rc<Self>, fullscreen: bool); fn tl_set_fullscreen(self: Rc<Self>, fullscreen: bool, ws: Option<Rc<WorkspaceNode>>);
fn tl_title_changed(&self); fn tl_title_changed(&self);
fn tl_set_parent(&self, parent: Rc<dyn ContainingNode>); fn tl_set_parent(&self, parent: Rc<dyn ContainingNode>);
fn tl_extents_changed(&self); fn tl_extents_changed(&self);
fn tl_set_workspace(&self, ws: &Rc<WorkspaceNode>); fn tl_set_workspace(&self, ws: &Rc<WorkspaceNode>);
fn tl_workspace_output_changed(&self); fn tl_workspace_output_changed(&self, prev: &Rc<OutputNode>, new: &Rc<OutputNode>);
fn tl_change_extents(self: Rc<Self>, rect: &Rect); fn tl_change_extents(self: Rc<Self>, rect: &Rect);
fn tl_set_visible(&self, visible: bool); fn tl_set_visible(&self, visible: bool);
fn tl_destroy(&self); fn tl_destroy(&self);
@ -74,10 +77,10 @@ impl<T: ToplevelNodeBase> ToplevelNode for T {
}); });
} }
fn tl_set_fullscreen(self: Rc<Self>, fullscreen: bool) { fn tl_set_fullscreen(self: Rc<Self>, fullscreen: bool, ws: Option<Rc<WorkspaceNode>>) {
let data = self.tl_data(); let data = self.tl_data();
if fullscreen { if fullscreen {
if let Some(ws) = data.workspace.get() { if let Some(ws) = ws.or_else(|| data.workspace.get()) {
data.set_fullscreen2(&data.state, self.clone(), &ws); data.set_fullscreen2(&data.state, self.clone(), &ws);
} }
} else { } else {
@ -132,14 +135,17 @@ impl<T: ToplevelNodeBase> ToplevelNode for T {
let prev = data.workspace.set(Some(ws.clone())); let prev = data.workspace.set(Some(ws.clone()));
self.tl_set_workspace_ext(ws); self.tl_set_workspace_ext(ws);
self.tl_data().property_changed(TL_CHANGED_WORKSPACE); self.tl_data().property_changed(TL_CHANGED_WORKSPACE);
let prev_id = prev.map(|p| p.output.get().id); let prev_output = match &prev {
let new_id = Some(ws.output.get().id); Some(n) => n.output.get(),
if prev_id != new_id { _ => ws.state.dummy_output.get().unwrap(),
self.tl_workspace_output_changed(); };
let new_output = ws.output.get();
if prev.is_none() || prev_output.id != new_output.id {
self.tl_workspace_output_changed(&prev_output, &new_output);
} }
} }
fn tl_workspace_output_changed(&self) { fn tl_workspace_output_changed(&self, prev: &Rc<OutputNode>, new: &Rc<OutputNode>) {
let data = self.tl_data(); let data = self.tl_data();
for sc in data.jay_screencasts.lock().values() { for sc in data.jay_screencasts.lock().values() {
sc.update_latch_listener(); sc.update_latch_listener();
@ -147,6 +153,13 @@ impl<T: ToplevelNodeBase> ToplevelNode for T {
for sc in data.ext_copy_sessions.lock().values() { for sc in data.ext_copy_sessions.lock().values() {
sc.update_latch_listener(); sc.update_latch_listener();
} }
if prev.id != new.id {
for handle in data.manager_handles.borrow().lock().values() {
handle.leave_output(prev);
handle.enter_output(new);
handle.send_done();
}
}
} }
fn tl_change_extents(self: Rc<Self>, rect: &Rect) { fn tl_change_extents(self: Rc<Self>, rect: &Rect) {
@ -322,6 +335,8 @@ pub struct ToplevelData {
pub identifier: Cell<ToplevelIdentifier>, pub identifier: Cell<ToplevelIdentifier>,
pub handles: pub handles:
CopyHashMap<(ClientId, ExtForeignToplevelHandleV1Id), Rc<ExtForeignToplevelHandleV1>>, CopyHashMap<(ClientId, ExtForeignToplevelHandleV1Id), Rc<ExtForeignToplevelHandleV1>>,
pub manager_handles:
CopyHashMap<(ClientId, ZwlrForeignToplevelHandleV1Id), Rc<ZwlrForeignToplevelHandleV1>>,
pub render_highlight: NumCell<u32>, pub render_highlight: NumCell<u32>,
pub jay_toplevels: CopyHashMap<(ClientId, JayToplevelId), Rc<JayToplevel>>, pub jay_toplevels: CopyHashMap<(ClientId, JayToplevelId), Rc<JayToplevel>>,
pub jay_screencasts: CopyHashMap<(ClientId, JayScreencastId), Rc<JayScreencast>>, pub jay_screencasts: CopyHashMap<(ClientId, JayScreencastId), Rc<JayScreencast>>,
@ -372,6 +387,7 @@ impl ToplevelData {
app_id: Default::default(), app_id: Default::default(),
identifier: Cell::new(id), identifier: Cell::new(id),
handles: Default::default(), handles: Default::default(),
manager_handles: Default::default(),
render_highlight: Default::default(), render_highlight: Default::default(),
jay_toplevels: Default::default(), jay_toplevels: Default::default(),
jay_screencasts: Default::default(), jay_screencasts: Default::default(),
@ -397,6 +413,10 @@ impl ToplevelData {
if let Some(parent) = self.parent.get() { if let Some(parent) = self.parent.get() {
parent.node_child_active_changed(tl, active_new, 1); parent.node_child_active_changed(tl, active_new, 1);
} }
for handle in self.manager_handles.borrow().lock().values() {
handle.send_state(active_new, self.is_fullscreen.get());
handle.send_done();
}
} }
} }
@ -453,6 +473,12 @@ impl ToplevelData {
handle.send_closed(); handle.send_closed();
} }
} }
{
let mut manager_handles = self.manager_handles.lock();
for handle in manager_handles.drain_values() {
handle.send_closed();
}
}
self.detach_node(node); self.detach_node(node);
self.property_changed(TL_CHANGED_DESTROYED); self.property_changed(TL_CHANGED_DESTROYED);
} }
@ -472,9 +498,29 @@ impl ToplevelData {
let id = self.identifier.get().to_string(); let id = self.identifier.get().to_string();
let title = self.title.borrow(); let title = self.title.borrow();
let app_id = self.app_id.borrow(); let app_id = self.app_id.borrow();
let activated = self.active();
let fullscreen = self.is_fullscreen.get();
let class;
let manager_app_id = match &self.kind {
ToplevelType::XWindow(w) => {
class = w.info.class.borrow();
class.as_deref().unwrap_or_default()
}
_ => &app_id,
};
for list in self.state.toplevel_lists.lock().values() { for list in self.state.toplevel_lists.lock().values() {
self.send_once(&toplevel, list, &id, &title, &app_id); self.send_once(&toplevel, list, &id, &title, &app_id);
} }
for manager in self.state.toplevel_managers.lock().values() {
self.manager_send_once(
&toplevel,
manager,
&title,
manager_app_id,
activated,
fullscreen,
);
}
} }
pub fn send(&self, toplevel: Rc<dyn ToplevelNode>, list: &ExtForeignToplevelListV1) { pub fn send(&self, toplevel: Rc<dyn ToplevelNode>, list: &ExtForeignToplevelListV1) {
@ -508,12 +554,76 @@ impl ToplevelData {
.set((handle.client.id, handle.id), handle.clone()); .set((handle.client.id, handle.id), handle.clone());
} }
pub fn manager_send(
&self,
toplevel: Rc<dyn ToplevelNode>,
manager: &ZwlrForeignToplevelManagerV1,
) {
let title = self.title.borrow();
let activated = self.active();
let fullscreen = self.is_fullscreen.get();
let app_id;
let class;
let manager_app_id = match &self.kind {
ToplevelType::XWindow(w) => {
class = w.info.class.borrow();
class.as_deref().unwrap_or_default()
}
_ => {
app_id = self.app_id.borrow();
&app_id
}
};
self.manager_send_once(
&toplevel,
manager,
&title,
manager_app_id,
activated,
fullscreen,
);
}
fn manager_send_once(
&self,
toplevel: &Rc<dyn ToplevelNode>,
manager: &ZwlrForeignToplevelManagerV1,
title: &str,
app_id: &str,
activated: bool,
fullscreen: bool,
) {
let opt = ToplevelOpt {
toplevel: Rc::downgrade(toplevel),
identifier: self.identifier.get(),
};
let handle = match manager.publish_toplevel(opt) {
None => return,
Some(handle) => handle,
};
if !app_id.is_empty() {
handle.send_app_id(app_id);
}
if !title.is_empty() {
handle.send_title(title);
}
handle.enter_output(&self.output());
handle.send_state(activated, fullscreen);
handle.send_done();
self.manager_handles
.set((handle.client.id, handle.id), handle.clone());
}
pub fn set_title(&self, title: &str) { pub fn set_title(&self, title: &str) {
*self.title.borrow_mut() = title.to_string(); *self.title.borrow_mut() = title.to_string();
for handle in self.handles.lock().values() { for handle in self.handles.lock().values() {
handle.send_title(title); handle.send_title(title);
handle.send_done(); handle.send_done();
} }
for handle in self.manager_handles.lock().values() {
handle.send_title(title);
handle.send_done();
}
} }
pub fn set_app_id(&self, app_id: &str) { pub fn set_app_id(&self, app_id: &str) {
@ -526,6 +636,10 @@ impl ToplevelData {
handle.send_app_id(app_id); handle.send_app_id(app_id);
handle.send_done(); handle.send_done();
} }
for handle in self.manager_handles.lock().values() {
handle.send_app_id(app_id);
handle.send_done();
}
self.property_changed(TL_CHANGED_APP_ID) self.property_changed(TL_CHANGED_APP_ID)
} }
@ -596,6 +710,10 @@ impl ToplevelData {
for seat in kb_foci { for seat in kb_foci {
node.clone().node_do_focus(&seat, Direction::Unspecified); node.clone().node_do_focus(&seat, Direction::Unspecified);
} }
for handle in self.manager_handles.lock().values() {
handle.send_state(self.active(), true);
handle.send_done();
}
} }
pub fn unset_fullscreen(&self, state: &Rc<State>, node: Rc<dyn ToplevelNode>) { pub fn unset_fullscreen(&self, state: &Rc<State>, node: Rc<dyn ToplevelNode>) {
@ -641,6 +759,10 @@ impl ToplevelData {
} }
} }
fd.placeholder.tl_destroy(); fd.placeholder.tl_destroy();
for handle in self.manager_handles.lock().values() {
handle.send_state(self.active(), false);
handle.send_done();
}
} }
pub fn set_visible(&self, node: &dyn Node, visible: bool) { pub fn set_visible(&self, node: &dyn Node, visible: bool) {

View file

@ -103,7 +103,7 @@ impl WorkspaceNode {
} }
pub fn set_output(&self, output: &Rc<OutputNode>) { pub fn set_output(&self, output: &Rc<OutputNode>) {
self.output.set(output.clone()); let old = self.output.set(output.clone());
for wh in self.ext_workspaces.lock().values() { for wh in self.ext_workspaces.lock().values() {
wh.handle_new_output(output); wh.handle_new_output(output);
} }
@ -111,38 +111,44 @@ impl WorkspaceNode {
jw.send_output(output); jw.send_output(output);
} }
self.update_has_captures(); self.update_has_captures();
struct OutputSetter<'a>(&'a Rc<OutputNode>); struct OutputSetter<'a> {
old: &'a Rc<OutputNode>,
new: &'a Rc<OutputNode>,
}
impl NodeVisitorBase for OutputSetter<'_> { impl NodeVisitorBase for OutputSetter<'_> {
fn visit_surface(&mut self, node: &Rc<WlSurface>) { fn visit_surface(&mut self, node: &Rc<WlSurface>) {
node.set_output(self.0); node.set_output(self.new);
} }
fn visit_container(&mut self, node: &Rc<ContainerNode>) { fn visit_container(&mut self, node: &Rc<ContainerNode>) {
node.tl_workspace_output_changed(); node.tl_workspace_output_changed(self.old, self.new);
node.node_visit_children(self); node.node_visit_children(self);
} }
fn visit_toplevel(&mut self, node: &Rc<XdgToplevel>) { fn visit_toplevel(&mut self, node: &Rc<XdgToplevel>) {
node.tl_workspace_output_changed(); node.tl_workspace_output_changed(self.old, self.new);
node.node_visit_children(self); node.node_visit_children(self);
} }
fn visit_float(&mut self, node: &Rc<FloatNode>) { fn visit_float(&mut self, node: &Rc<FloatNode>) {
node.after_ws_move(self.0); node.after_ws_move(self.new);
node.node_visit_children(self); node.node_visit_children(self);
} }
fn visit_xwindow(&mut self, node: &Rc<Xwindow>) { fn visit_xwindow(&mut self, node: &Rc<Xwindow>) {
node.tl_workspace_output_changed(); node.tl_workspace_output_changed(self.old, self.new);
node.node_visit_children(self); node.node_visit_children(self);
} }
fn visit_placeholder(&mut self, node: &Rc<PlaceholderNode>) { fn visit_placeholder(&mut self, node: &Rc<PlaceholderNode>) {
node.tl_workspace_output_changed(); node.tl_workspace_output_changed(self.old, self.new);
node.node_visit_children(self); node.node_visit_children(self);
} }
} }
let mut visitor = OutputSetter(output); let mut visitor = OutputSetter {
old: &old,
new: output,
};
self.node_visit_children(&mut visitor); self.node_visit_children(&mut visitor);
for stacked in self.stacked.iter() { for stacked in self.stacked.iter() {
stacked.deref().clone().node_visit(&mut visitor); stacked.deref().clone().node_visit(&mut visitor);

View file

@ -1126,6 +1126,11 @@ impl Wm {
let mut buf = vec![]; let mut buf = vec![];
let property_changed = || { let property_changed = || {
if let Some(window) = data.window.get() { if let Some(window) = data.window.get() {
let class = data.info.class.borrow();
for handle in window.toplevel_data.manager_handles.lock().values() {
handle.send_app_id(class.as_deref().unwrap_or_default());
handle.send_done();
}
window.toplevel_data.property_changed(TL_CHANGED_CLASS_INST); window.toplevel_data.property_changed(TL_CHANGED_CLASS_INST);
} }
}; };
@ -2458,7 +2463,7 @@ impl Wm {
} }
if fullscreen != data.info.fullscreen.get() { if fullscreen != data.info.fullscreen.get() {
if let Some(w) = data.window.get() { if let Some(w) = data.window.get() {
w.tl_set_fullscreen(fullscreen); w.tl_set_fullscreen(fullscreen, None);
} }
} }
data.info.fullscreen.set(fullscreen); data.info.fullscreen.set(fullscreen);

View file

@ -0,0 +1,79 @@
# requests
request set_maximized {
}
request unset_maximized {
}
request set_minimized {
}
request unset_minimized {
}
request activate {
seat: id(wl_seat)
}
request close {
}
request set_rectangle {
surface: id(wl_surface),
x: i32,
y: i32,
width: i32,
height: i32,
}
request destroy {
}
request set_fullscreen (since = 2) {
output: id(wl_output)
}
request unset_fullscreen (since = 2) {
}
# events
event title {
title: str,
}
event app_id {
app_id: str,
}
event output_enter {
output: id(wl_output),
}
event output_leave {
output: id(wl_output),
}
event state {
state: array(u32),
}
event done {
}
event closed {
}
event parent (since = 3) {
parent: id(zwlr_foreign_toplevel_handle_v1)
}

View file

@ -0,0 +1,15 @@
# requests
request stop {
}
# events
event toplevel {
toplevel: id(zwlr_foreign_toplevel_handle_v1)
}
event finished {
}